Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Rename original browser copy action #13676

Merged
merged 1 commit into from
Sep 3, 2020
Merged

PR: Rename original browser copy action #13676

merged 1 commit into from
Sep 3, 2020

Conversation

goanpeca
Copy link
Member

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)
  • Copy action error has been fixed
  • I could not reproduce the error for Select all only for the Copy action

help

Issue(s) Resolved

Fixes #13665

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

@goanpeca goanpeca self-assigned this Aug 31, 2020
@goanpeca goanpeca requested a review from steff456 August 31, 2020 23:21
@goanpeca goanpeca added this to the v5.0alpha2 milestone Aug 31, 2020
@goanpeca goanpeca mentioned this pull request Sep 1, 2020
Closed
@steff456
Copy link
Member

steff456 commented Sep 2, 2020

/show binder

@github-actions
Copy link

github-actions bot commented Sep 2, 2020

Binder 👈 Launch a Binder instance on this branch

steff456
steff456 previously approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@steff456 steff456 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalthviz this PR is working as expected and is ready to merge as soon all tests pass,

Thanks @goanpeca!

dalthviz
dalthviz reviewed Sep 2, 2020
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goanpeca left a comment. Besides that this LGTM 👍

spyder/widgets/browser.py Outdated Show resolved Hide resolved
@goanpeca goanpeca force-pushed the fix/help-context-menu-actions branch from 0b6d261 to abea018 Compare September 3, 2020 13:29
dalthviz
dalthviz approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goanpeca LGTM 👍

@dalthviz dalthviz merged commit 1aac18c into spyder-ide:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalthviz dalthviz dalthviz approved these changes

@steff456 steff456 steff456 left review comments

Assignees

@goanpeca goanpeca

Labels
None yet
Projects
None yet
Milestone
v5.0alpha2
Development

Successfully merging this pull request may close these issues.

Spyder crashes with select all + copy all in the help pane
3 participants
@goanpeca @steff456 @dalthviz