Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix several issues with the plots pane from API migration #13677

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Sep 1, 2020

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

@dalthviz added the fixes for the different reported issues.
plots

Issue(s) Resolved

Fixes #13659

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

@goanpeca goanpeca self-assigned this Sep 1, 2020
@goanpeca goanpeca added this to the v5.0alpha2 milestone Sep 1, 2020
@dalthviz
Copy link
Member

dalthviz commented Sep 1, 2020

/show binder

@github-actions
Copy link

github-actions bot commented Sep 1, 2020

Binder 👈 Launch a Binder instance on this branch

@dalthviz
Copy link
Member

dalthviz commented Sep 1, 2020

@juanis2112 could do a manual test of the fixes please? Thanks!

@juanis2112
Copy link
Contributor

All the issues reported in #13659 were fixed in this PR. Everything looks fine for me.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goanpeca LGTM 👍

@dalthviz dalthviz merged commit 14e70b0 into spyder-ide:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plots pane issues and details
3 participants