Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add some instructions for maintainers #13871

Merged
merged 3 commits into from
Oct 1, 2020

Conversation

ccordoba12
Copy link
Member

This details several things that maintainers need to know for their job.

@dalthviz, please take a look at this one.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 checking maybe could be worthy to add too the handling of spyder-kernels PRs related to issues in Spyder that don't modify code inside Spyder? (merge in Spyder kernels, PR in Spyder to update the subrepo, etc).

Also this could be the place to add the info about how to configure the automatic messages used for issues, right?

Also improve wording of previous instruction
@ccordoba12
Copy link
Member Author

ccordoba12 commented Sep 30, 2020

Thanks @dalthviz for the review. I added instructions to perform the extra tasks you mentioned above.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 I was checking and maybe this file should be added to the setup.cfg? Other than that this LGTM 👍

@ccordoba12
Copy link
Member Author

Thanks @ccordoba12 I was checking and maybe this file should be added to the setup.cfg?

Good point! I did that in my last commit.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 LGTM 👍

@dalthviz dalthviz merged commit af8d852 into spyder-ide:master Oct 1, 2020
@ccordoba12 ccordoba12 deleted the maintenance-guide branch November 2, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants