-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add some instructions for maintainers #13871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ccordoba12 checking maybe could be worthy to add too the handling of spyder-kernels PRs related to issues in Spyder that don't modify code inside Spyder? (merge in Spyder kernels, PR in Spyder to update the subrepo, etc).
Also this could be the place to add the info about how to configure the automatic messages used for issues, right?
Also improve wording of previous instruction
Thanks @dalthviz for the review. I added instructions to perform the extra tasks you mentioned above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ccordoba12 I was checking and maybe this file should be added to the setup.cfg
? Other than that this LGTM 👍
Good point! I did that in my last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ccordoba12 LGTM 👍
This details several things that maintainers need to know for their job.
@dalthviz, please take a look at this one.