Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Change colors for kernel errors in IPython console #13963

Merged
merged 2 commits into from
Oct 11, 2020

Conversation

juanis2112
Copy link
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Changed the colors of the kernel error in the IPython console to enhance contrast. I used the new darker red proposed by @isabela-pf for errors in spyder-ide/ux-improvements#13.

Screenshot 2020-10-11 at 3 21 41 PM

Screenshot 2020-10-11 at 3 33 37 PM

Issue(s) Resolved

Fixes #13754

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
Juanis2112

@juanis2112 juanis2112 added this to the v4.2.0 milestone Oct 11, 2020
@ccordoba12 ccordoba12 changed the title PR: Change colors for kernel errors in Ipython console PR: Change colors for kernel errors in IPython console Oct 11, 2020
@ccordoba12
Copy link
Member

ccordoba12 commented Oct 11, 2020

Screenshot 2020-10-11 at 3 33 37 PM

Perhaps this red is too intense for the light theme?

@juanis2112, could you upload a new screenshot with the current red on the light theme?

@juanis2112
Copy link
Contributor Author

Screenshot 2020-10-11 at 3 33 37 PM

Perhaps this red is too intense for the light theme?

@juanis2112, could you upload a new screenshot with the current red on the light theme?

Screenshot 2020-10-11 at 3 58 38 PM

Yeah maybe for the light mode the lighter red looks better

ccordoba12
ccordoba12 previously approved these changes Oct 11, 2020
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juanis2112, looks good to me now.

@ccordoba12 ccordoba12 changed the base branch from master to 4.x October 11, 2020 22:12
@ccordoba12 ccordoba12 dismissed their stale review October 11, 2020 22:12

The base branch was changed.

@ccordoba12 ccordoba12 merged commit 76a078f into spyder-ide:4.x Oct 11, 2020
ccordoba12 added a commit that referenced this pull request Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change colors for IPython console error message
2 participants