-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Migrate completion plugin to the new API #14314
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @andfoy for your hard work on this one! I left an initial review for you.
This restores the right ordering of LSP requests when a project is open at startup.
23a84f9
to
61279d5
Compare
Also improve text for some options on the General tab of its config page.
Also fix style issues.
Also fix minor style issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andfoy, this is a new review for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @andfoy for this!! It's a fantastic improvement!
In my testing of this PR all the options of the preference pane are working as expected! Thanks @andfoy for this work |
Description of Changes
This PR migrates the completion plugin (former CompletionManager) to the new API. As part of this PR, we also introduce a CompletionProvider interface, from which all completion providers inherit. The new CompletionPlugin will take all the providers (whom are registered via entrypoints), initialize them and manage them.
Issue(s) Resolved
Fixes #12192
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @andfoy