Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Migrate Spyder preference dialog to a plugin of the new API #14536

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

andfoy
Copy link
Member

@andfoy andfoy commented Jan 4, 2021

Description of Changes

This PR migrates Spyder preference dialog to a plugin for Spyder 5. It also adds a new API for adding configuration tabs to any page via SpyderPreferencesTab

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #14537

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @andfoy

@andfoy andfoy added this to the v5.0alpha4 milestone Jan 4, 2021
@andfoy andfoy self-assigned this Jan 4, 2021
@andfoy andfoy marked this pull request as draft January 4, 2021 22:54
@pep8speaks
Copy link

pep8speaks commented Jan 5, 2021

Hello @andfoy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 73:17: E731 do not assign a lambda expression, use a def
Line 105:17: E731 do not assign a lambda expression, use a def
Line 163:5: E303 too many blank lines (2)

Line 158:42: E227 missing whitespace around bitwise or shift operator

Line 34:33: E127 continuation line over-indented for visual indent

Comment last updated at 2021-01-15 22:15:02 UTC

@andfoy andfoy marked this pull request as ready for review January 7, 2021 20:07
@andfoy andfoy changed the title [WIP] PR: Migrate Spyder preference dialog to a plugin of the new API PR: Migrate Spyder preference dialog to a plugin of the new API Jan 7, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @andfoy for this! I left an initial review for you.

spyder/api/preferences.py Show resolved Hide resolved
spyder/plugins/maininterpreter/tests/test_confpage.py Outdated Show resolved Hide resolved
spyder/plugins/preferences/api.py Outdated Show resolved Hide resolved
spyder/plugins/preferences/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/pylint/tests/test_pylint_config_dialog.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andfoy! I think this is almost ready, except for two minor comments.

spyder/plugins/preferences/api.py Show resolved Hide resolved
@andfoy andfoy force-pushed the add_preferences_plugin branch 2 times, most recently from d5d40e6 to 07ae054 Compare January 14, 2021 23:58
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andfoy, great work with this new plugin!

@ccordoba12 ccordoba12 merged commit dc0a219 into spyder-ide:master Jan 15, 2021
@andfoy andfoy deleted the add_preferences_plugin branch January 16, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Spyder preferences dialog to a separate plugin
3 participants