-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Migrate Spyder preference dialog to a plugin of the new API #14536
Conversation
Hello @andfoy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-01-15 22:15:02 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @andfoy for this! I left an initial review for you.
spyder/plugins/completion/languageserver/tests/test_lsp_config_dialog.py
Outdated
Show resolved
Hide resolved
spyder/plugins/ipythonconsole/tests/test_ipython_config_dialog.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andfoy! I think this is almost ready, except for two minor comments.
d5d40e6
to
07ae054
Compare
07ae054
to
e634682
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andfoy, great work with this new plugin!
Description of Changes
This PR migrates Spyder preference dialog to a plugin for Spyder 5. It also adds a new API for adding configuration tabs to any page via
SpyderPreferencesTab
Issue(s) Resolved
Fixes #14537
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @andfoy