PR: Add button to show and hide replace widget from find widget #14628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @juanis2112! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-01-25 16:52:07 UTC |
juanis2112
force-pushed
the
replace_widget
branch
2 times, most recently
from
7964c00
to
1a5c957
Compare
juanis2112
force-pushed
the
replace_widget
branch
from
1a5c957
to
e6aadbc
Compare
ccordoba12
reviewed
Jan 24, 2021
There was a problem hiding this comment.
Great addition @juanis2112. I left a minor suggestion, otherwise looks good to me.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added button to show and hide replace widget from find widget as discussed in spyder-ide/ux-improvements#25
Issue(s) Resolved
Fixes spyder-ide/ux-improvements#25
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
Juanis2112