Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add palette files with color roles #14665

Merged
merged 43 commits into from
Mar 25, 2021

Conversation

juanis2112
Copy link
Contributor

@juanis2112 juanis2112 commented Jan 29, 2021

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

This PR adds the color roles from the Spyder's palette for both the light and dark theme.
It also replaces all the colors from the elements in spyder with the colors from either the qdarkstyle palette or the spyder palette.
I will be posting screenshots of the elements changed as I change them to make sure we like the colors.

The following files still have hardcoded colors and will be changed once the colors on the variable explorer are migrated:

  • spyder/external-deps/spyder-kernels/spyder_kernels/console/kernel.py
  • spyder/spyder/widgets/arraybuilder.py
  • spyder/external-deps/spyder-kernels/spyder_kernels/utils/nsview.py
  • spyder/spyder/plugins/variableexplorer/widgets/tests/test_namespacebrowser.py
  • spyder/spyder/widgets/tests/test_collectioneditor.py

The following files still have hardcoded colors which we will leave that way because they are black:

  • spyder/spyder/plugins/editor/utils/editor.py -> Lines 48,49
  • spyder/spyder/app/tests/test_mainwindow.py

The following files still have hardcoded colors which we will figure out in the future:

  • spyder/spyder/plugins/console/utils/ansihandler.py
  • spyder/spyder/utils/syntaxhighlighters.py

Issue(s) Resolved

Fixes spyder-ide/ux-improvements#26
Fixes spyder-ide/ux-improvements#13

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@pep8speaks

This comment has been minimized.

@juanis2112 juanis2112 force-pushed the role-colors-dark branch 3 times, most recently from 691e04e to d340148 Compare March 2, 2021 03:48
@juanis2112
Copy link
Contributor Author

juanis2112 commented Mar 2, 2021

Tour dialog:
Screenshot 2021-03-02 at 10 14 27 AM

@juanis2112
Copy link
Contributor Author

juanis2112 commented Mar 2, 2021

IPython Console pager
Screenshot 2021-03-02 at 10 15 20 AM

Screenshot 2021-03-03 at 10 47 46 AM

@juanis2112
Copy link
Contributor Author

juanis2112 commented Mar 2, 2021

Find in files invalid regex color
Screenshot 2021-03-02 at 10 27 47 AM

Screenshot 2021-03-03 at 10 48 38 AM

@juanis2112
Copy link
Contributor Author

juanis2112 commented Mar 2, 2021

Profiler results
Screenshot 2021-03-02 at 1 32 33 PM

Screenshot 2021-03-03 at 10 50 21 AM

@juanis2112
Copy link
Contributor Author

Kite dialog:
Screenshot 2021-03-04 at 1 24 32 AM

Screenshot 2021-03-04 at 1 27 11 AM

@juanis2112
Copy link
Contributor Author

Code Analysis:

Screenshot 2021-03-04 at 10 26 23 AM

Screenshot 2021-03-04 at 10 26 13 AM

Screenshot 2021-03-04 at 10 26 00 AM

Screenshot 2021-03-04 at 10 24 55 AM

Screenshot 2021-03-04 at 10 24 39 AM

Screenshot 2021-03-04 at 10 24 25 AM

@juanis2112
Copy link
Contributor Author

Internal console:
Screenshot 2021-03-04 at 11 27 29 AM
Screenshot 2021-03-04 at 11 26 33 AM

We might need to modify group color 4 for light mode a little bit. I think the contrast with the white is not enough (see the green text over the white background). What do you think @isabela-pf?

@isabela-pf
Copy link
Collaborator

We might need to modify group color 4 for light mode a little bit. I think the contrast with the white is not enough (see the green text over the white background). What do you think @isabela-pf?

I agree. I think it's because I thought they were being used only in the variable explorer, so I'm happy to update those.

@juanis2112
Copy link
Contributor Author

juanis2112 commented Mar 12, 2021

Warning:
Screenshot 2021-03-12 at 6 52 14 PM
Screenshot 2021-03-12 at 6 51 22 PM

@ccordoba12
Copy link
Member

Thanks @juanis2112, they look better to me now, but we can discuss about that in our next meeting.

@juanis2112
Copy link
Contributor Author

juanis2112 commented Mar 15, 2021

The last commit removesthe occurrences button and sets highlighting the occurrences in the find/replace widget by default.
It fixes spyder-ide/ux-improvements#26 and closes #14632
Screenshot 2021-03-22 at 12 44 27 PM

@ccordoba12
Copy link
Member

It fixes spyder-ide/ux-improvements#26 and closes #14632

Please add this to the the Issue(s) Resolved section of the first comment in this PR.

Also, could you upload again the screenshot you tried to post in your last comment? Unfortunately, it wasn't uploaded correctly to Github.

@ccordoba12 ccordoba12 changed the title Add palette files with color roles PR: Add palette files with color roles Mar 23, 2021
@ccordoba12 ccordoba12 added this to the v5.0beta1 milestone Mar 24, 2021
@ccordoba12 ccordoba12 marked this pull request as ready for review March 24, 2021 05:06
@ccordoba12
Copy link
Member

/show binder

@github-actions
Copy link

github-actions bot commented Mar 24, 2021

Binder 👈 Launch a Binder instance on this branch

@juanis2112
Copy link
Contributor Author

Help pane:
Screenshot 2021-03-24 at 7 50 16 PM
Screenshot 2021-03-24 at 7 50 07 PM
Screenshot 2021-03-24 at 7 48 32 PM
Screenshot 2021-03-24 at 7 48 22 PM

Online Help:
Screenshot 2021-03-24 at 8 03 33 PM
Screenshot 2021-03-24 at 8 02 51 PM

IPython Console:
Screenshot 2021-03-24 at 7 54 22 PM
Screenshot 2021-03-24 at 7 53 41 PM

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juanis2112 for your hard work on the new color palette for Spyder 5! This is finally ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the highlight occurrences option from the find widget New palette for Spyder's UI
4 participants