-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add palette files with color roles #14665
Conversation
This comment has been minimized.
This comment has been minimized.
691e04e
to
d340148
Compare
79b4a5d
to
b773831
Compare
We might need to modify group color 4 for light mode a little bit. I think the contrast with the white is not enough (see the green text over the white background). What do you think @isabela-pf? |
I agree. I think it's because I thought they were being used only in the variable explorer, so I'm happy to update those. |
Thanks @juanis2112, they look better to me now, but we can discuss about that in our next meeting. |
The last commit removesthe occurrences button and sets highlighting the occurrences in the find/replace widget by default. |
Please add this to the the Also, could you upload again the screenshot you tried to post in your last comment? Unfortunately, it wasn't uploaded correctly to Github. |
f41f5d7
to
feffc01
Compare
/show binder |
feffc01
to
4d74e70
Compare
8301f22
to
7f24d85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @juanis2112 for your hard work on the new color palette for Spyder 5! This is finally ready!
Description of Changes
This PR adds the color roles from the Spyder's palette for both the light and dark theme.
It also replaces all the colors from the elements in spyder with the colors from either the qdarkstyle palette or the spyder palette.
I will be posting screenshots of the elements changed as I change them to make sure we like the colors.
The following files still have hardcoded colors and will be changed once the colors on the variable explorer are migrated:
The following files still have hardcoded colors which we will leave that way because they are black:
The following files still have hardcoded colors which we will figure out in the future:
Issue(s) Resolved
Fixes spyder-ide/ux-improvements#26
Fixes spyder-ide/ux-improvements#13
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: