Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add flag to prevent adding initial empty QAction on Mac for non-migrated menus #14682

Merged
merged 1 commit into from Feb 3, 2021

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Feb 2, 2021

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Flag to preserve UI even with a mix of migrated and non-migrated menus

Preview:
menuMac

Issue(s) Resolved

Fixes #14661

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz
Copy link
Member Author

dalthviz commented Feb 2, 2021

Note: Also, @ccordoba12 @steff456, seems like there is a bug with the menuBar on Mac. You need to make it disappear and appear again (for example changing to another application and going back to Spyder) to be able to interact with it. Seems like this issue is also present in 4.x as far as I could test. Is there an issue created already for that?

@ccordoba12
Copy link
Member

Seems like this issue is also present in 4.x as far as I could test. Is there an issue created already for that?

I think this happens because we use python instead of pythonw to start Spyder in development mode. I think @steff456 and @juanis2112 reported it before, but it shouldn't be an issue for our Mac app or when you install Spyder with conda install spyder.

Could you test that to be sure?

@steff456
Copy link
Member

steff456 commented Feb 3, 2021

This PR fixes the empty menu entry 🎉

image

The other issue we haven't been able to fix it, but I think that we are accustomed to changing the app once it opens for now.

Copy link
Member

@steff456 steff456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is ready for merge!!

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit a52676f into spyder-ide:master Feb 3, 2021
@ccordoba12 ccordoba12 mentioned this pull request Feb 3, 2021
27 tasks
@dalthviz
Copy link
Member Author

dalthviz commented Feb 3, 2021

Could you test that to be sure?

Seems like this only happens indeed when running with python instead of pythonw (when running pythonw bootstrap.py the menus work without the need to change the focus from the application)

@ccordoba12
Copy link
Member

Great! Thanks @dalthviz for the confirmation.

@steff456, I thought you said running pythow bootstrap.py generated an error for you. Could you verify that again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There's a blank space in the menus in the top in macOS
3 participants