PR: Add a new Application plugin #14586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
changed the title
ccordoba12
changed the title
dalthviz
force-pushed
the
application_plugin
branch
9 times, most recently
from
451af9a
to
04858df
Compare
dalthviz
force-pushed
the
application_plugin
branch
from
e6879a9
to
5cfb2e0
Compare
dalthviz
changed the title
ccordoba12
reviewed
Feb 3, 2021
There was a problem hiding this comment.
Thanks @dalthviz for your work on this! This looks almost ready, except for the minor comments I left below.
dalthviz
force-pushed
the
application_plugin
branch
from
1005d21
to
ff3722a
Compare
Application: Initial Application plugin structure. Move Help/Mainmenu application actions to the correct place Application: Fix trouble action test Application: Move Tools menu and Windows env vars dialog to the Application plugin API: Add option to create an icon from an image file Application: Fix Editor tools menu actions Application: Change PYTHONPATH manager action creation Toolbar: Fix before action addition. Add before_section param. Add Application plugin actions to the main toolbar Application: Handle Windows env variables dialog addition to the main menus Application: Testing Application: Revert PYTHONPATH Manager migration (needs its own plugin). Add quit action to the main menu from the Console plugin Application: Testing Application: Migrate Restart and Quit actions. Migrate File menu Toolbar: Fix code style issues Application: Testing Application: Initial migration of main preferences config page Preferences: Fix preferences ADDITIONAL_CONF_OPTIONS parsing. Application: Testing Application: Move configpage from Preferences and remove use of GeneralConfigPage Application: Remove file_menu references in mainwindow. Fix Editor setup new window Application: Move report missing dependencies to Application plugin Application: Fix code style issue and comments Application: Use restart method on mainwindow. Add comment for action name to map shortcuts Mainmenu: Remove dynamic kwarg for File and Tools menus
dalthviz
force-pushed
the
application_plugin
branch
from
846c83e
to
ee5dfd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
PYTHONPATH Manager(PYTHONPATH will be its own plugin)Quit(part of the Console plugin)before_sectionparam for items addition.Vertical title bars in panes(Removed)Animated toolbars and panes(Removed)Tear off menus(Removed)Part of #13527