Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix for search/find close button error (Variable Explorer) #15032

Merged
merged 6 commits into from Mar 28, 2021

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Mar 27, 2021

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Multiple instances of the finder (close button + line edit) were being created. The main problem was not related to creating the whole finder element multiple times but the close button (which was like declaring the same action multiple times).

Now only one instance of the finder is created.

TODO:

  • How to keep text input and the visibility of the search bar for the different Name Space Browser (i.e one could have the search visible while another one could have it invisible, also one could have some text in it while the other is blank)

Preview

vefinder

Issue(s) Resolved

Fixes #15010

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@pep8speaks
Copy link

pep8speaks commented Mar 27, 2021

Hello @dalthviz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-28 19:36:38 UTC

@dalthviz dalthviz self-assigned this Mar 27, 2021
@dalthviz dalthviz changed the title [WIP] PR: Initial fix for search/find close button error (Variable Explorer) PR: Initial fix for search/find close button error (Variable Explorer) Mar 27, 2021
@dalthviz dalthviz changed the title PR: Initial fix for search/find close button error (Variable Explorer) PR: Fix for search/find close button error (Variable Explorer) Mar 27, 2021
@ccordoba12 ccordoba12 added this to the v5.0.0 milestone Mar 27, 2021
Before that was done only for the visible nsb
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dalthviz for your help with this!

@ccordoba12
Copy link
Member

Note: I took the opportunity to fix a bug I found while testing this: the variable explorer options were not applied to all namespace browsers, just to the visible one.

@ccordoba12 ccordoba12 merged commit bd0310e into spyder-ide:master Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error report dialog pop ups when creating a new console
3 participants