Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Move PluginMainContainer and PluginMainWidget to their own modules #15038

Merged
merged 3 commits into from
Mar 28, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Mar 27, 2021

Description of Changes

  • Those classes are perhaps the most important ones of our new API, so I think it's better to move them to their own modules so they are easier to find and use.
  • I also took the opportunity to remove unused imports in a lot of places.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@ccordoba12 ccordoba12 added this to the v5.0.0 milestone Mar 27, 2021
@ccordoba12 ccordoba12 self-assigned this Mar 27, 2021
@pep8speaks
Copy link

Hello @ccordoba12! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 143:23: W292 no newline at end of file

Line 50:1: E402 module level import not at top of file
Line 52:1: E402 module level import not at top of file
Line 53:1: E402 module level import not at top of file
Line 71:1: E402 module level import not at top of file
Line 85:1: E402 module level import not at top of file
Line 87:1: E402 module level import not at top of file
Line 93:1: E402 module level import not at top of file

@ccordoba12 ccordoba12 merged commit 520d099 into spyder-ide:master Mar 28, 2021
@ccordoba12 ccordoba12 deleted the move-imports branch March 28, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants