Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Some style fixes #15081

Merged
merged 8 commits into from Apr 2, 2021
Merged

PR: Some style fixes #15081

merged 8 commits into from Apr 2, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Apr 1, 2021

Description of Changes

This PR does the following:

  • Adjust style for QDarkstyle 3.0.2 and pin it to that version.
  • Align tabs to the left and fix padding in tab names on macOS.
  • Fix padding for tab in History
  • Fix checkboxes for togglable actions of panes and toolbars menus.

Fixes #15082.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.0.0 milestone Apr 1, 2021
@dpizetta
Copy link
Contributor

dpizetta commented Apr 1, 2021

Hi, @ccordoba12 just mention here to simplify instead of opening a new issue. There are some blank dots (the border/background is not matching for the pannels). May it wouldn't be easy to find the origin of it. Tks

image

@pep8speaks

This comment has been minimized.

@ccordoba12
Copy link
Member Author

ccordoba12 commented Apr 1, 2021

Thanks @dpizetta, we noticed that problem too and we plan to fix it in a later release.

subrepo:
  subdir:   "external-deps/qdarkstyle"
  merged:   "e8b424fa8"
upstream:
  origin:   "https://github.com/ColinDuquesnoy/QDarkStyleSheet.git"
  branch:   "develop"
  commit:   "ea408544f"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"
This is pinned (for now) to a specific version to prevent our style
being messed up in a future release.
@ccordoba12 ccordoba12 merged commit bd80f81 into spyder-ide:master Apr 2, 2021
@ccordoba12 ccordoba12 deleted the style-fixes branch April 2, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project menu indicator overlapped by its text, missing icons
3 participants