Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix error when detecting spyder-kernels version #15100

Merged
merged 3 commits into from
Apr 5, 2021

Conversation

ccordoba12
Copy link
Member

Description of Changes

This fixes the detection of spyder-kernels at startup in our dependencies mechanism.

Issue(s) Resolved

Fixes #15091.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.0.1 milestone Apr 3, 2021
@ccordoba12 ccordoba12 self-assigned this Apr 3, 2021
Copy link

@Kashish1000 Kashish1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change SPYDER_KERNELS_REQVER = '>=2.0.1;<2.1.0' to
SPYDER_KERNELS_REQVER = '>=2.0.1'
This will fix this error

@real-yfprojects
Copy link
Contributor

change SPYDER_KERNELS_REQVER = '>=2.0.1;<2.1.0' to
SPYDER_KERNELS_REQVER = '>=2.0.1'
This will fix this error

The <2.1.0 is probably there, so that changes in new versions which aren't backwards compatible are noticed and told the user.
But if they comply to Semantic Versioning the minor version number should not increase in case of backwards incompatible changes. Instead the major (first) version number should increase. The line should changed to

 SPYDER_KERNELS_REQVER = '>=2.0.1;<3.0.0'

@ccordoba12
Copy link
Member Author

@Kashish1000, that's not the right solution.

@real-yfprojects, we know what we're doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants