Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Increase padding in checkboxes for old PyQt versions #15127

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Apr 5, 2021

Description of Changes

We thought this problem only happened on macOS, but it was really caused by old PyQt versions (i.e. less than 5.12).

Issue(s) Resolved

Fixes #15116.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

We thought this problem only happened in macOS, but it was really caused
by old PyQt versions.
@ccordoba12 ccordoba12 added this to the v5.0.1 milestone Apr 5, 2021
@ccordoba12 ccordoba12 self-assigned this Apr 5, 2021
@ccordoba12
Copy link
Member Author

We tested this with @steff456 in all operating systems and it's working as expected.

@ccordoba12 ccordoba12 changed the base branch from master to 5.x April 6, 2021 00:36
@ccordoba12 ccordoba12 merged commit 688a529 into spyder-ide:5.x Apr 6, 2021
@ccordoba12 ccordoba12 deleted the fix-checkboxes branch April 6, 2021 00:37
ccordoba12 added a commit to ccordoba12/spyder that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu text covered by icon(s)
1 participant