-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Fix a couple of bugs in the statusbar #15354
Conversation
@impact27 can you please test this PR with your Spyder settings to see if this change fixes your issue? |
It fixes the issue but the autocompletion/linting doesn't work. |
@impact27, that won't work because Spyder needs to be properly installed for our completion architecture to work now. |
But couldn't there be a patch if spyder is not part of a proper distribution?
|
Or would that just work if I have a local copy of the git? |
This works for me: #15382 |
@steff456, if the the LSP provider is deactivated in preferences: we still try to show its widget in the status bar: The idea is to hide it when that provider is disabled. And please do the same for Kite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good @steff456, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @steff456!
Description of Changes
Fixes #15322
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: Steff456