Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make tour a plugin in the new API #15488

Merged
merged 24 commits into from
Jul 5, 2021

Conversation

juanis2112
Copy link
Contributor

@juanis2112 juanis2112 commented May 3, 2021

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

This PR is based on #14276

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@pep8speaks
Copy link

pep8speaks commented May 3, 2021

Hello @juanis2112! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 312:80: E501 line too long (93 > 79 characters)

Comment last updated at 2021-07-04 23:39:10 UTC

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juanis2112 for your work on this! It looks pretty good so far! I left a bunch of suggestions to remove unnecessary code and some questions for you.

Also, please check if you need to reapply the changes added in PRs #15052, #15067, #15036 and #14420, because those were done after the initial migration PR made by Gonzalo.

spyder/api/plugins.py Outdated Show resolved Hide resolved
spyder/plugins/tours/container.py Outdated Show resolved Hide resolved
spyder/plugins/tours/container.py Outdated Show resolved Hide resolved
spyder/plugins/tours/container.py Outdated Show resolved Hide resolved
spyder/plugins/tours/container.py Outdated Show resolved Hide resolved
spyder/plugins/tours/widgets.py Outdated Show resolved Hide resolved
spyder/plugins/tours/widgets.py Outdated Show resolved Hide resolved
spyder/plugins/tours/widgets.py Outdated Show resolved Hide resolved
spyder/plugins/tours/widgets.py Outdated Show resolved Hide resolved
spyder/plugins/tours/widgets.py Outdated Show resolved Hide resolved
juanis2112 and others added 4 commits May 30, 2021 21:30
@juanis2112 juanis2112 force-pushed the tour-migration branch 3 times, most recently from 436d73d to ddd1093 Compare May 31, 2021 03:51
@ccordoba12 ccordoba12 added this to the v5.1.0 milestone May 31, 2021
@ccordoba12 ccordoba12 changed the title PR: Migrate tour to new API PR: Migrate tour to the new API May 31, 2021
@juanis2112 juanis2112 force-pushed the tour-migration branch 5 times, most recently from b426dca to 26bf96d Compare June 2, 2021 21:17
@juanis2112 juanis2112 marked this pull request as ready for review June 2, 2021 22:21
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @juanis2112 so far! Last comments on my side, then this should be finally ready.

spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/plugins/tours/container.py Outdated Show resolved Hide resolved
spyder/plugins/tours/container.py Outdated Show resolved Hide resolved
return _("Provide interative tours.")

def get_icon(self):
return self.create_icon('keyboard')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanis2112, you forgot to address this comment. I suggest adding mdi-map-outline to the icon_manager dict with the tour key, and using it here.

spyder/plugins/tours/container.py Show resolved Hide resolved
@ccordoba12
Copy link
Member

Also, please remove the file spyder/app/tour.py in this PR, because it's not needed anymore.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @juanis2112 for this. You did a great work on this PR!

@ccordoba12 ccordoba12 changed the title PR: Migrate tour to the new API PR: Make tour a plugin in the new API Jul 5, 2021
@ccordoba12 ccordoba12 merged commit 086776e into spyder-ide:5.x Jul 5, 2021
ccordoba12 added a commit that referenced this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants