-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Update Spyder's logo #15829
PR: Update Spyder's logo #15829
Conversation
/show binder |
Screenshots from binder after 69a0d1d I'm definitely seeing less changes than I expected for changing eight files. On to the next experiment we go… 🧪 |
eb13b89 and 79d3775 shows no changes! 😦 Fresh screenshots for proof: I'm also finding that several of the images in |
I think I've made all the changes based on team feedback, so let me know if it looks like anything is still incorrect or missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @isabela-pf!
HI @isabela-pf, the logo version in this PR still contain the line I pointed out in #13181 (comment). I interpreted your “:+1:” as agreement to change that detail, so I’m reminding you of it. |
Description of Changes
This PR updates the logos in
img_src
to reflect the voting in ux-improvements #50 and discussion in #13181. This changes how the logo appears in Spyder itself, Spyder's application icons, and in the readme.I've marked it as draft because there are still some images I haven't replaced as I try to figure out why they are separate files when some of them look the same visually.
Issue(s) Resolved
Fixes #13181
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
isabela-pf