Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update Spyder's logo #15829

Merged
merged 13 commits into from
Jul 6, 2021
Merged

PR: Update Spyder's logo #15829

merged 13 commits into from
Jul 6, 2021

Conversation

isabela-pf
Copy link
Collaborator

@isabela-pf isabela-pf commented Jun 9, 2021

Description of Changes

This PR updates the logos in img_src to reflect the voting in ux-improvements #50 and discussion in #13181. This changes how the logo appears in Spyder itself, Spyder's application icons, and in the readme.

I've marked it as draft because there are still some images I haven't replaced as I try to figure out why they are separate files when some of them look the same visually.

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Screen Shot 2021-06-15 at 4 47 11 PM

Screen Shot 2021-06-15 at 4 42 01 PM

Screen Shot 2021-06-15 at 4 42 18 PM

Issue(s) Resolved

Fixes #13181

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
isabela-pf

@isabela-pf
Copy link
Collaborator Author

/show binder

@github-actions
Copy link

github-actions bot commented Jun 9, 2021

Binder 👈 Launch a Binder instance on this branch

@isabela-pf
Copy link
Collaborator Author

Screenshots from binder after 69a0d1d
Screen Shot 2021-06-11 at 4 09 32 PM
Screen Shot 2021-06-11 at 4 10 04 PM
Screen Shot 2021-06-11 at 4 10 14 PM
Screen Shot 2021-06-11 at 4 10 49 PM

I'm definitely seeing less changes than I expected for changing eight files. On to the next experiment we go… 🧪

@isabela-pf
Copy link
Collaborator Author

isabela-pf commented Jun 12, 2021

eb13b89 and 79d3775 shows no changes! 😦 Fresh screenshots for proof:
Screen Shot 2021-06-11 at 5 43 40 PM
Screen Shot 2021-06-11 at 5 44 10 PM
Screen Shot 2021-06-11 at 5 44 32 PM
Screen Shot 2021-06-11 at 5 44 47 PM

I'm also finding that several of the images in img_src don't seem to be called anywhere. If someone can verify this, I'd be grateful. Images I think aren't called elsewhere in Spyder:
spyder-reset.svg
spyder-bdist_wininst.bmp
spyder-bdist_wininst.svg
spyder-big.svg
spyder-original.svg
spyder-small.svg
spyder-title_bbg.svg
spyder-title-horiz.svg
spyder-title.svg

@ccordoba12 ccordoba12 changed the title Update Spyder's logo PR: Update Spyder's logo Jun 15, 2021
@ccordoba12 ccordoba12 added this to the v5.1.0 milestone Jun 15, 2021
@isabela-pf
Copy link
Collaborator Author

Changes in the main spyder/images directory! Here's how that's looking.
Screen Shot 2021-06-15 at 4 41 30 PM
Screen Shot 2021-06-15 at 4 42 01 PM
Screen Shot 2021-06-15 at 4 42 18 PM

@isabela-pf
Copy link
Collaborator Author

Last commit just updated the SVG being used for the application icon. ✨ Huzzah!
Screen Shot 2021-06-15 at 4 47 11 PM

@isabela-pf isabela-pf marked this pull request as ready for review June 16, 2021 00:13
@isabela-pf
Copy link
Collaborator Author

I think I've made all the changes based on team feedback, so let me know if it looks like anything is still incorrect or missing.

@steff456 steff456 self-requested a review June 30, 2021 22:09
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isabela-pf!

@ccordoba12 ccordoba12 merged commit 32428ed into spyder-ide:5.x Jul 6, 2021
ccordoba12 added a commit that referenced this pull request Jul 6, 2021
@flying-sheep
Copy link
Contributor

HI @isabela-pf, the logo version in this PR still contain the line I pointed out in #13181 (comment). I interpreted your “:+1:” as agreement to change that detail, so I’m reminding you of it.

@isabela-pf isabela-pf mentioned this pull request Jul 12, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants