Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix updated Spyder logos #16007

Merged
merged 7 commits into from
Jul 21, 2021
Merged

PR: Fix updated Spyder logos #16007

merged 7 commits into from
Jul 21, 2021

Conversation

isabela-pf
Copy link
Collaborator

@isabela-pf isabela-pf commented Jul 12, 2021

Description of Changes

Removes the upper left web in the corner of the last round of logos per request.

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes the last comment in #15829.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
isabela-pf

@isabela-pf
Copy link
Collaborator Author

/show binder

@github-actions
Copy link

Binder 👈 Launch a Binder instance on this branch

@isabela-pf
Copy link
Collaborator Author

Here's how it looks in binder:

Screen Shot 2021-07-12 at 1 56 35 PM

Screen Shot 2021-07-12 at 1 56 57 PM

Screen Shot 2021-07-12 at 1 57 23 PM

Screen Shot 2021-07-12 at 1 57 35 PM

Screen Shot 2021-07-12 at 1 59 00 PM

Screen Shot 2021-07-12 at 1 59 13 PM

@isabela-pf
Copy link
Collaborator Author

isabela-pf commented Jul 12, 2021

@ccordoba12 ccordoba12 changed the title Fix updated Spyder logos PR: Fix updated Spyder logos Jul 13, 2021
@ccordoba12 ccordoba12 added this to the v5.1.0 milestone Jul 13, 2021
Copy link
Member

@steff456 steff456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest commit works as expected for Mac Qt 5.9 and Qt 5.12. Thanks for this work @isabela-pf!

@ccordoba12 ccordoba12 merged commit 6c1550c into spyder-ide:5.x Jul 21, 2021
ccordoba12 added a commit that referenced this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants