Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix tests for IPykernel 6 #15958

Merged
merged 3 commits into from
Jul 3, 2021
Merged

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jul 1, 2021

Description of Changes

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@ccordoba12 ccordoba12 added this to the v5.1.0 milestone Jul 1, 2021
@pep8speaks
Copy link

pep8speaks commented Jul 1, 2021

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 245:10: E111 indentation is not a multiple of four
Line 245:10: E117 over-indented
Line 287:10: E111 indentation is not a multiple of four
Line 287:10: E117 over-indented

Comment last updated at 2021-07-03 14:57:30 UTC

…m/ccordoba12/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "64aff677b"
upstream:
  origin:   "https://github.com/ccordoba12/spyder-kernels.git"
  branch:   "test-ipykernel-6"
  commit:   "64aff677b"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"
…der-ide/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "b034d7913"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "2.x"
  commit:   "b034d7913"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"
@ccordoba12 ccordoba12 merged commit 67c7c84 into spyder-ide:5.x Jul 3, 2021
@ccordoba12 ccordoba12 deleted the ipykernel-6 branch July 3, 2021 15:51
ccordoba12 added a commit that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants