PR: Migrate the IPython Console to the new API #16324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @dalthviz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-11-03 18:11:07 UTC |
dalthviz
force-pushed
the
clean_ipyconsole_migration
branch
8 times, most recently
from
d1380f8
to
bd6b397
Compare
dalthviz
force-pushed
the
clean_ipyconsole_migration
branch
5 times, most recently
from
dfc81bb
to
bcbc3e4
Compare
dalthviz
force-pushed
the
clean_ipyconsole_migration
branch
from
b7906b6
to
ab9d2d7
Compare
dalthviz
force-pushed
the
clean_ipyconsole_migration
branch
from
42f0062
to
a88911e
Compare
ccordoba12
reviewed
Oct 6, 2021
There was a problem hiding this comment.
Thanks a lot @dalthviz for your hard work on this one! It looks pretty good.
This is an initial review for you, up to ipythonconsole/plugin.py, so you can start working on it. I'll try to leave another review for what's missing before the end of the week.
Merged
3 tasks
dalthviz
force-pushed
the
clean_ipyconsole_migration
branch
from
032de7a
to
c196396
Compare
dalthviz
changed the title
dalthviz
force-pushed
the
clean_ipyconsole_migration
branch
2 times, most recently
from
c15b7f5
to
a4677e1
Compare
dalthviz
changed the title
ccordoba12
reviewed
Oct 15, 2021
There was a problem hiding this comment.
Hey @dalthviz, this is my second review. Things look pretty good, except for a couple of things we should take a closer look at.
dalthviz
force-pushed
the
clean_ipyconsole_migration
branch
from
ff432de
to
0bbbf9f
Compare
dalthviz
changed the title
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
…rnel and register handlers from the Editor
…ange register/unregister kernel handlers method place to kernels section
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
…enu, MENU_SEPARATOR. Improve docstring for signals and remove commented code
…t. Add logic for conf change with sig_prompt_ready. Simplify set_elapsed_time conf change
…se update_actions instead of custom method. Remove unused code and comments
…focus_changed directly
…hen creating kernels
dalthviz
force-pushed
the
clean_ipyconsole_migration
branch
from
92a2df3
to
2550a11
Compare
ccordoba12
changed the title
3 tasks
ccordoba12
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
Thanks a lot @dalthviz for all your hard work on this! It's finally ready!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
IPython Console to Spyder 5 plugin API
Supersedes #12749 #15934
Depends on #15922
Issue(s) Resolved
Fixes #12194.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz