PR: Add a way to create plugins like Plots and the Variable explorer to the API #15922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-10-07 13:59:06 UTC |
ccordoba12
reviewed
Jun 23, 2021
There was a problem hiding this comment.
This is a great refactor @impact27! Thanks a lot for it!
It'll allow anyone that wants to create plugins like Plots and the Variable Explorer to easily do it from now on.
ccordoba12
changed the title
ccordoba12
changed the title
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
impact27
force-pushed
the
refactor_shell_connect
branch
from
8f29bdf
to
eae4136
Compare
ccordoba12
force-pushed
the
refactor_shell_connect
branch
from
0891f3d
to
00dff47
Compare
…eleted It's not really necessary because it was only used in the Variable Explorer to call set_namespace_view_settings and refresh_namespacebrowser, but the right place to do that is in connect_external_kernel.
This allows other plugins to take certain actions after that happens.
ccordoba12
force-pushed
the
refactor_shell_connect
branch
from
00dff47
to
b0a278d
Compare
ccordoba12
force-pushed
the
refactor_shell_connect
branch
from
f23d45b
to
1660675
Compare
ccordoba12
added a commit
that referenced
this pull request
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Issue(s) Resolved
Fixes #15921
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: