Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Avoid calling auto-formatting when such an operation is taking place #16539

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Oct 4, 2021

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #16280

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@ccordoba12 ccordoba12 changed the title avoid formatting from stale ref PR: Avoid calling auto-formatting when such an operation is taking place Oct 6, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@impact27, could you add a test for this so we're sure we don't introduce regressions in the future?

rear1019
rear1019 previously approved these changes Oct 11, 2021
Copy link
Contributor

@rear1019 rear1019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code changes I think that they should fix #16280. I did some short testing and confirmed this.

@ccordoba12 ccordoba12 added this to the v5.2.0 milestone Oct 11, 2021
@ccordoba12
Copy link
Member

Ok, thanks for the review @rear1019! I'll close your PRs here and Spyder-kernels then.

@ccordoba12 ccordoba12 changed the base branch from master to 5.x October 12, 2021 15:32
@ccordoba12 ccordoba12 dismissed rear1019’s stale review October 12, 2021 15:32

The base branch was changed.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks a lot for your help @impact27!

Also, thanks @rear1019 for the manual testing!

@ccordoba12 ccordoba12 merged commit 016f3f4 into spyder-ide:5.x Oct 12, 2021
ccordoba12 added a commit that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoformat files on save when running them causes lines addition to code
3 participants