Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Constrain IPython to be less than 7.28.0 for macOS installer #16829

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Nov 15, 2021

Description of Changes

Constrain IPython<7.28.0 for macOS installer only, until #16651 can be merged.

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@mrclary

@mrclary
Copy link
Contributor Author

mrclary commented Nov 15, 2021

@impact27, can you verify that the installer test passes in PR #14025 if this change is incorporated?

@ccordoba12 ccordoba12 changed the title Constrain IPython<7.28.0 for macOS installer PR: Constrain IPython to be less rhan 7.28.0 for macOS installer Nov 15, 2021
@ccordoba12 ccordoba12 added this to the v5.2.0 milestone Nov 15, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 merged commit b686308 into spyder-ide:5.x Nov 15, 2021
ccordoba12 added a commit that referenced this pull request Nov 15, 2021
@ccordoba12 ccordoba12 changed the title PR: Constrain IPython to be less rhan 7.28.0 for macOS installer PR: Constrain IPython to be less than 7.28.0 for macOS installer Nov 15, 2021
@mrclary mrclary deleted the incorrectly-compiled branch November 16, 2021 01:40
@impact27
Copy link
Contributor

@impact27, can you verify that the installer test passes in PR #14025 if this change is incorporated?

It does not unfortunately

@ccordoba12
Copy link
Member

Sorry for merging this too eagerly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants