Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix errors when other plugins are not available (Editor) #16945

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

ccordoba12
Copy link
Member

Description of Changes

  • Spyder was crashing at start-up if Projects is not available, so we need to check for its presence first before trying to use it.
  • I also took the opportunity to do the same for some actions that depend on the IPython console.

Issue(s) Resolved

Fixes #16931.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

We were not checking for Projects and the IPython console presence
before running certain actions.
@ccordoba12 ccordoba12 self-assigned this Dec 2, 2021
@ccordoba12 ccordoba12 added this to the v5.2.1 milestone Dec 2, 2021
This fixes our tests with my latest changes and also avoids the old way
of accessing plugins through self.main
@ccordoba12 ccordoba12 merged commit 1ba518d into spyder-ide:5.x Dec 3, 2021
@ccordoba12 ccordoba12 deleted the issue-16931 branch December 3, 2021 00:02
ccordoba12 added a commit that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant