Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix renaming files in the editor after the folder that contains them was renamed in Files #17132

Merged
merged 2 commits into from
Jan 1, 2022

Conversation

ccordoba12
Copy link
Member

Description of Changes

  • This was broken due to a couple of wrong signal signatures.
  • Add a test to avoid regressions in the future.

Issue(s) Resolved

Fixes #17129.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.2.2 milestone Jan 1, 2022
@ccordoba12 ccordoba12 self-assigned this Jan 1, 2022
@ccordoba12 ccordoba12 changed the title PR: Fix renaming files in the editor after the folder thar contains them was renamed in Files PR: Fix renaming files in the editor after the folder that contains them was renamed in Files Jan 1, 2022
@ccordoba12 ccordoba12 merged commit 4d23772 into spyder-ide:5.x Jan 1, 2022
@ccordoba12 ccordoba12 deleted the issue-17129 branch January 1, 2022 20:50
ccordoba12 added a commit that referenced this pull request Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant