-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Catch leaks in the test suite #17205
Conversation
Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-01-21 16:41:32 UTC |
The goal here is to check that no file or process is opened in a test and not closed. While working on this I noticed #17213. This bug is caused by closing the stdout and stderr file without stopping the restarter. The restarter therefore tries to restart the kernel, but can’t access the files, as they are closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @impact27 for your help with this! It looks almost ready to me, with the exception of one test you changed to make it pass (which I think is incorrect).
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks @impact27!
Description of Changes
Issue(s) Resolved
Fixes #17213
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: