Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Do not test for leaks on Windows to avoid tests stall #17234

Merged
merged 4 commits into from
Jan 24, 2022

Conversation

impact27
Copy link
Contributor

Description of Changes

test for stalls

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@impact27 impact27 changed the title PR: simplify test_mainwindow leak tests PR: Do not test for leaks on windows to avoid test stall Jan 24, 2022
@ccordoba12 ccordoba12 added this to the v5.3.0 milestone Jan 24, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27 for your prompt help with this!

@ccordoba12 ccordoba12 changed the title PR: Do not test for leaks on windows to avoid test stall PR: Do not test for leaks on Windows to avoid tests stall Jan 24, 2022
@ccordoba12 ccordoba12 merged commit ebc7e48 into spyder-ide:5.x Jan 24, 2022
ccordoba12 added a commit that referenced this pull request Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants