PR: Remove extra blank lines when running statements with input() (IPython console)
#17559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ternal-deps/qtconsole subrepo: subdir: "external-deps/qtconsole" merged: "e8c16bfd5" upstream: origin: "https://github.com/jupyter/qtconsole.git" branch: "master" commit: "e8c16bfd5" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
…ithub.com/ccordoba12/qtconsole.git external-deps/qtconsole subrepo: subdir: "external-deps/qtconsole" merged: "0cc9c0bff" upstream: origin: "https://github.com/ccordoba12/qtconsole.git" branch: "input-prompt-sep" commit: "0cc9c0bff" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
That's because the next qtconsole release will depend on it
ccordoba12
force-pushed
the
issue-16504
branch
4 times, most recently
from
9e9e4d3
to
b066fef
Compare
dalthviz
previously approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Thanks @ccordoba12 ! This LGTM 👍
Also, I guess first jupyter/qtconsole#501 needs to be merged and then the subrepo here updated for this to be finished, right?
|
Yes, let me do that so you can merge this one. |
…jupyter/qtconsole.git external-deps/qtconsole subrepo: subdir: "external-deps/qtconsole" merged: "bcab5aaf8" upstream: origin: "https://github.com/jupyter/qtconsole.git" branch: "master" commit: "bcab5aaf8" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596" [ci skip]
dalthviz
approved these changes
Mar 28, 2022
dalthviz
added a commit
that referenced
this pull request
Mar 28, 2022
9 tasks
This was referenced Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
input()in the IPython console.RichJupyterWidget.Issue(s) Resolved
Fixes #16504
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12