-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Show symbols for namespace packages in the Outline #19332
Conversation
This makes easier to contribute to that fixture separately from the tests that use it.
…om/ccordoba12/python-lsp-server.git external-deps/python-lsp-server subrepo: subdir: "external-deps/python-lsp-server" merged: "0d654c287" upstream: origin: "https://github.com/ccordoba12/python-lsp-server.git" branch: "more-symbol-fixes" commit: "0d654c287" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-09-06 21:53:59 UTC |
de461e0
to
a831bb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ccordoba12 ! Left a comment regarding the moving of other things from test_mainwindow.py
to conftest.py
.
Seems like a test on MacOS is failing (could it be caused due to the changes on the python-lsp-server
?)
Also, could you add a screenshot of the outline before/after the changes here to understand better how the outline should be working? Thanks!
It seems more related to the refactoring I did to move the
Ok, will do. |
Also fix error with tests using the preload_project marker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ccordoba12 ! Checked locally and seems like this is working as expected and 👍
I guess then this is only missing the merge of python-lsp/python-lsp-server#261 and updating here the subrepo, right @ccordoba12 ?
Yep, that's what's left. |
…lsp/python-lsp-server.git external-deps/python-lsp-server subrepo: subdir: "external-deps/python-lsp-server" merged: "6501e9eb8" upstream: origin: "https://github.com/python-lsp/python-lsp-server.git" branch: "develop" commit: "6501e9eb8" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
@ccordoba12 could it be that other changes done for v1.6.0 to the python-language-server are causing completion tests to fail? |
This adds repeated entries in our completion widget
Yep, the error was caused by a new option added in PR python-lsp/python-lsp-server#246, but I deactivated it here because it leads to repeated entries in our completion widget: |
Description of Changes
__init__.py
in the root of their repository.main_window
fixture to its correspondingconftest.py
file to make it easier to contribute to it.add_import_symbols
isFalse
python-lsp/python-lsp-server#261.Before
No symbols for namespace packages
Showing relative imports in multiple lines as symbols
After
Symbols are shown for namespace packages
Relative imports in multiple lines are not shown
Issue(s) Resolved
Fixes #16406.
Fixes #16352.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12