PR: Show symbols for namespace packages in the Outline

[ccordoba12]

Description of Changes

• Those are packages that don't have an __init__.py in the root of their repository.
• Also avoid showing relative imports in the Outline.
• Move main_window fixture to its corresponding conftest.py file to make it easier to contribute to it.
• Add tests to catch future regressions for these bugs.
• Depends on PR: Include all symbols that Jedi reports as declared in a file when add_import_symbols is False python-lsp/python-lsp-server#261.

Before

• No symbols for namespace packages

  

• Showing relative imports in multiple lines as symbols

  

After

• Symbols are shown for namespace packages

  

• Relative imports in multiple lines are not shown

  

Issue(s) Resolved

Fixes #16406.
Fixes #16352.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

[pep8speaks]

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file external-deps/python-lsp-server/pylsp/plugins/jedi_completion.py:

Line 57:80: E501 line too long (84 > 79 characters)
Line 67:80: E501 line too long (119 > 79 characters)

• In the file external-deps/python-lsp-server/pylsp/plugins/symbols.py:

Line 63:80: E501 line too long (86 > 79 characters)
Line 85:80: E501 line too long (97 > 79 characters)
Line 86:80: E501 line too long (96 > 79 characters)
Line 87:80: E501 line too long (99 > 79 characters)

• In the file external-deps/python-lsp-server/test/plugins/test_pylint_lint.py:

Line 73:80: E501 line too long (95 > 79 characters)
Line 83:80: E501 line too long (95 > 79 characters)

Comment last updated at 2022-09-06 21:53:59 UTC

[dalthviz]

Thanks @ccordoba12 ! Left a comment regarding the moving of other things from test_mainwindow.py to conftest.py.

Seems like a test on MacOS is failing (could it be caused due to the changes on the python-lsp-server?)

Also, could you add a screenshot of the outline before/after the changes here to understand better how the outline should be working? Thanks!

[ccordoba12]

Seems like a test on MacOS is failing (could it be caused due to the changes on the python-lsp-server?)

It seems more related to the refactoring I did to move the main_window fixture to conftest.py. I'll take a look at it.

Also, could you add a screenshot of the outline before/after the changes here to understand better how the outline should be working? Thanks!

Ok, will do.

[dalthviz]

Thanks @ccordoba12 ! Checked locally and seems like this is working as expected and 👍

I guess then this is only missing the merge of python-lsp/python-lsp-server#261 and updating here the subrepo, right @ccordoba12 ?

[ccordoba12]

I guess then this is only missing the merge of python-lsp/python-lsp-server#261 and updating here the subrepo, right @ccordoba12 ?

Yep, that's what's left.

[dalthviz]

@ccordoba12 could it be that other changes done for v1.6.0 to the python-language-server are causing completion tests to fail?

[ccordoba12]

could it be that other changes done for v1.6.0 to the python-language-server are causing completion tests to fail?

Yep, the error was caused by a new option added in PR python-lsp/python-lsp-server#246, but I deactivated it here because it leads to repeated entries in our completion widget: