Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Pin Sphinx to version 5.1.1 to prevent errors on MacOS installer build #19620

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Sep 26, 2022

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

To prevent the MacOS installer build check from failing on PRs ping sphinx to be 5.1.1

Issue(s) Resolved

Fixes #19618

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz added this to the v5.4.0 milestone Sep 26, 2022
@dalthviz dalthviz self-assigned this Sep 26, 2022
@mrclary mrclary changed the title PR: Ping py2app to version 0.28.2 to prevent errors on MacOS installer build PR: Pin py2app to version 0.28.2 to prevent errors on MacOS installer build Sep 26, 2022
@mrclary
Copy link
Contributor

mrclary commented Sep 26, 2022

@dalthviz, well, maybe it's not py2app? the same error is occurring. I'll investigate.

@mrclary
Copy link
Contributor

mrclary commented Sep 26, 2022

The only other differences I see in the build environment are:

  • Successful -> setuptools=65.3.0; sphinx=5.1.1
  • Unsuccessful -> setuptools=65.4.0; sphinx=5.2.0.post0

We could try pinning these instead, one-by-one, to see if any any are the culprit.

@dalthviz
Copy link
Member Author

Seems like the problem was Sphinx 👍

@dalthviz dalthviz changed the title PR: Pin py2app to version 0.28.2 to prevent errors on MacOS installer build PR: Pin Sphinx to version 5.1.1 to prevent errors on MacOS installer build Sep 26, 2022
@mrclary mrclary merged commit 939548c into spyder-ide:5.x Sep 27, 2022
mrclary added a commit to mrclary/spyder that referenced this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants