PR: Temporary fix for function test_no_empty_file_items

[stevetracvc]

looks like the results of findinfiles.find() aren't deterministic and it's causing test_no_empty_file_items to fail

Description of Changes

• Wrote at least one-line docstrings (for any new functions)
• Added unit test(s) covering the changes (if testable)

• Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #19602

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
stevetracvc

[stevetracvc]

What's with this sphinxcontrib error in the MacOS app test?

[dalthviz]

I think maybe some packages got new releases and those are incompatible with the way the MacOS installer is build. So that error is unrelated with the changes here

[dalthviz]

Thank you for the help with this @stevetracvc ! This LGTM and the failing check seems unrelated with this 👍

However, just in case, is okay if we merge this without taking into account the failing MacOS installer build check @ccordoba12 ?

[dalthviz]

Also @stevetracvc could you rebase this change on top of the 5.x branch, please? Thanks!

[stevetracvc]

@dalthviz I think I rebased it correctly...I'm not the greatest with git. It still says master at the top. Last time I just redid the PR hah

[dalthviz]

Thanks @stevetracvc , I think the rebase worked! I changed the base branch on this PR at the top and it still shows just one file as modified 👍

Seems like your git-fu has improved :)

[dalthviz]

Note: This needs a new rebase on top of 5.x after #19620 gets merged to fix the check failure

[stevetracvc]

Note: This needs a new rebase on top of 5.x after #19620 gets merged to fix the check failure

OK, I think I did that, and the sphinx issue is gone. Is there a better way than me doing

git fetch upstream
git rebase upstream/5.x
git push --force

I don't like the force push part, is there a better way? And I'll need to do it with my other active PR too, once this one gets merged, so that it can pass all tests.

[dalthviz]

Thanks @stevetracvc for your patience with this! And yes that's the way to do it in case you update your PR with a rebase 👍

Regarding the force push, it's needed due to the rebase (which changes the git commit history). The other way to achive synchronization is by merging but then if you already have work done, a merge commit will be put in the history. In such a case, you can just push (so no need of force push since you are just adding the merge commit to the history).

And yes, after this PR gets merged, all the other open PRs will need to either rebase on top the latest 5.x or merge with the latest 5.x to get the changes here and then be able to pass the checks