Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add dialog to confirm downloaded installer installation and update related code organization (Application) #19700

Merged
merged 4 commits into from
Oct 11, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spyder/plugins/application/widgets/install.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ class UpdateInstallerDialog(QDialog):
Parameters
----------
current_value: int
Number of bits downloaded until now.
Size of the data downloaded until now.
total: int
Total expected number of bits to be downloaded.
Total size file expected to be downloaded.
dalthviz marked this conversation as resolved.
Show resolved Hide resolved
"""

sig_installation_status = Signal(str, str)
Expand Down
20 changes: 20 additions & 0 deletions spyder/workers/updates.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,28 @@ class WorkerDownloadInstaller(QObject):
Worker that donwloads standalone installers for Windows
and MacOS without blocking the Spyder user interface.
"""

sig_ready = Signal(str)
"""
Signal to inform that the worker has finished successfully.

Parameters
----------
installer_path: str
Path where the downloaded installer is located.
"""

sig_download_progress = Signal(int, int)
"""
Signal to get the download progress.

Parameters
----------
current_value: int
Size of the data downloaded until now.
total: int
Total size file expected to be downloaded.
dalthviz marked this conversation as resolved.
Show resolved Hide resolved
"""

def __init__(self, parent, latest_release_version):
QObject.__init__(self)
Expand Down