PR: Add dialog to confirm downloaded installer installation and update related code organization (Application) #19700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
force-pushed
the
part_issue_19112
branch
from
af76aab
to
8217f16
Compare
dalthviz
force-pushed
the
part_issue_19112
branch
from
8217f16
to
aa44dd2
Compare
|
Note: Seems like the MacOS installer workflow is failing due to the release of |
dalthviz
changed the title
Yep, looks like we should pin that to |
dalthviz
force-pushed
the
part_issue_19112
branch
from
aa44dd2
to
282e80b
Compare
dalthviz
changed the title
…and update code organization
dalthviz
force-pushed
the
part_issue_19112
branch
from
282e80b
to
8a1fbe2
Compare
dalthviz
changed the title
ccordoba12
reviewed
Oct 10, 2022
There was a problem hiding this comment.
This looks pretty nice! Thanks a lot @dalthviz for your work on it.
Code style and strings Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
dalthviz
force-pushed
the
part_issue_19112
branch
from
0c00796
to
c7fa3a0
Compare
ccordoba12
reviewed
Oct 10, 2022
There was a problem hiding this comment.
@dalthviz, last small suggestions for you, then this should be ready.
Signals docstrings changes Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
ccordoba12
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Thanks a lot @dalthviz, and @jsbautista too, for your great job on this! The auto-update functionality is shaping so nicely! Keep up the good work.
ccordoba12
added a commit
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
See #19112 (comment)
A preview showing the new dialog without having the installer downloaded:
A preview showing the new dialog when the installer was already downloaded previously:
Issue(s) Resolved
Part of #19112
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz