Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Only create the application update status bar for standalone installers, increase timer interval to start checking for updates and change cancel download button shape (Application) #19871

Merged
merged 3 commits into from
Oct 18, 2022
Merged

PR: Only create the application update status bar for standalone installers, increase timer interval to start checking for updates and change cancel download button shape (Application) #19871

merged 3 commits into from
Oct 18, 2022

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Oct 17, 2022 •
edited
Loading

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #19868

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz self-assigned this Oct 17, 2022
@dalthviz dalthviz added this to the v5.4.0 milestone Oct 17, 2022
@dalthviz dalthviz changed the title [WIP] PR: Only create the application update status bar for standalone installers and increase timer interval to start checking for updates (Application)) [WIP] PR: Only create the application update status bar for standalone installers and increase timer interval to start checking for updates (Application) Oct 17, 2022
@dalthviz dalthviz changed the title [WIP] PR: Only create the application update status bar for standalone installers and increase timer interval to start checking for updates (Application) PR: Only create the application update status bar for standalone installers and increase timer interval to start checking for updates (Application) Oct 18, 2022
@dalthviz dalthviz changed the title PR: Only create the application update status bar for standalone installers and increase timer interval to start checking for updates (Application) PR: Only create the application update status bar for standalone installers, increase timer interval to start checking for updates and change cancel download button shape(Application) Oct 18, 2022
@dalthviz
Copy link
Member Author

As a side note, a preview of how things are working with the latest changes added with PR #19700 and #19793 on MacOS:

update_mac

ccordoba12
ccordoba12 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dalthviz!

@ccordoba12 ccordoba12 changed the title PR: Only create the application update status bar for standalone installers, increase timer interval to start checking for updates and change cancel download button shape(Application) PR: Only create the application update status bar for standalone installers, increase timer interval to start checking for updates and change cancel download button shape (Application) Oct 18, 2022
@ccordoba12 ccordoba12 merged commit 5e271fe into spyder-ide:5.x Oct 18, 2022
ccordoba12 added a commit that referenced this pull request Oct 18, 2022
@ccordoba12
Merge from 5.x: PR #19871
2c0bf20 
Fixes #19868
@dalthviz dalthviz mentioned this pull request Oct 19, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

Labels
Installers type:Enhancement
Projects
None yet
Milestone
v5.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dalthviz @ccordoba12