PR: Add validation to prevent calling uninitialized application_update_status widget on conda installations (Application)
#20036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion_update_status widget on conda installations
ccordoba12
approved these changes
Nov 12, 2022
ccordoba12
changed the title
application_update_status widget on conda installations (Application)application_update_status widget on conda installations (Application)
ccordoba12
changed the title
application_update_status widget on conda installations (Application)application_update_status widget on conda installations (Application)
ccordoba12
added a commit
that referenced
this pull request
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The application update status bar is only initialized for the standalone installers but no validations were added to prevent calling it inside the check updates logic available for all types of Spyder installations (standalone installers, conda, pip, etc).
Issue(s) Resolved
Fixes #20035
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz