PR: Update conda-based installers #20056
Conversation
mrclary
force-pushed
the
update-installers-conda
branch
2 times, most recently
from
905b41a
to
a005cd5
Compare
dalthviz
changed the title
…a-pkgs job is skipped (releases).
Properly allow for arbitrary repo source via environment variable, including Spyder. Put cloned source into DIST directory to prevent unclean repository state.
Try --skip-existing to see what happens
Try --build-id-pat={n} to help with long path names on windows
Don't load and dump spec file for each package
Enclose in try statement in order to try to build all packages, regardless of failure
mrclary
force-pushed
the
update-installers-conda
branch
3 times, most recently
from
d64507e
to
a1c91af
Compare
Do not clone Spyder source if it is current repo; this causes problems for determining patch on CI.
… data is stored in the instance.
Note that ruamel.yaml will not allow duplicate keys (e.g. 'build.string'), so regular expression find/replace must be used to patch the meta.yaml files.
mrclary
force-pushed
the
update-installers-conda
branch
5 times, most recently
from
8b442d1
to
60bd3c3
Compare
mrclary
force-pushed
the
update-installers-conda
branch
3 times, most recently
from
b925eac
to
a1dba82
Compare
…conda-pkgs job was skipped
mrclary
force-pushed
the
update-installers-conda
branch
from
a1dba82
to
1b8364c
Compare
mrclary
force-pushed
the
update-installers-conda
branch
2 times, most recently
from
c487ca2
to
42a5d74
Compare
mrclary
force-pushed
the
update-installers-conda
branch
from
42a5d74
to
62341ee
Compare
|
@ccordoba12, this should be ready for review now. |
There was a problem hiding this comment.
A couple of minor comments for you @mrclary, otherwise looks good to me.
| @@ -1,313 +0,0 @@ | |||
| From 40db10418cf9b46a70b48026d202d4474d62b99a Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
Why is this patch no longer necessary? I thought you needed to do several adjustments to our source code for the installers to work as expected.
There was a problem hiding this comment.
The patch is still necessary. However, I think it will be simpler to create the file on-demand rather than track and update it.
Currently, necessary changes are made on the installers-conda-patch branch, but then a separate PR must be made on the 5.x branch to update the patch file when the installers-conda-patch gets new commits. With this PR we don't need to track and update a patch file on the 5.x branch, rather the patch file is created when the spyder conda package is built.
There was a problem hiding this comment.
Ok, thanks for the clarification. I didn't understand where the patch went.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Description of Changes
--no-testflag rather than removing test directives inmeta.yamlspyder-kernelsfeedstock