PR: Better split test suite between slow and fast slots in CIs and other improvements for CIs #20425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
force-pushed
the
better-split-test-suite
branch
2 times, most recently
from
96cdc56
to
d2230cd
Compare
ccordoba12
changed the title
ccordoba12
force-pushed
the
better-split-test-suite
branch
from
d2230cd
to
f71e493
Compare
ccordoba12
changed the title
ccordoba12
force-pushed
the
better-split-test-suite
branch
3 times, most recently
from
77ed3bd
to
33d5875
Compare
ccordoba12
force-pushed
the
better-split-test-suite
branch
2 times, most recently
from
50e4afc
to
f44dc17
Compare
ccordoba12
changed the title
- This only works for CIs. In other words, the distinction between slow and fast tests doesn't apply when running them locally. - Skip a couple of tests that started to fail with this approach.
- This significantly reduces the necessary time to do that - Also fix test_completions_environment, which was failing a lot
This is provided by Github actions natively now.
ccordoba12
force-pushed
the
better-split-test-suite
branch
from
f44dc17
to
fd1415f
Compare
ccordoba12
changed the title
ccordoba12
changed the title
|
Pinging @juliangilbey about this one because you could be interested on this change. |
ccordoba12
added a commit
that referenced
this pull request
Jan 28, 2023
This was referenced Jan 28, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Remove
slowPytest marker and instead mark all main window tests, and a percentage of the IPython console ones on Linux and Mac, as slow on CIs (locally there won't be any distinction between slow and fast tests).This will make our slow slots finish faster compared to the fast ones (the first ones are taking two times more than the later).
This also allow us to adjust the amount of tests marked as slow/fast per operating system.
Use micromamba to create our test environment on CIs. This significantly reduces the necessary time to do that.
Remove script and code in our workflows that manually checked for
[ci skip]in commit messages. That functionality is provided natively now by Github actions.Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12