PR: Restore pickle import in py3compat.py and some fixes to the main window tests
#20450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids running that test several times to make it pass.
ccordoba12
force-pushed
the
issue-20430
branch
from
e6e848f
to
af2a37e
Compare
- That's because that function is not a test but an auxiliary function. - Also, mark some tests as flaky.
ccordoba12
force-pushed
the
issue-20430
branch
from
55aa5ec
to
98b691f
Compare
ccordoba12
changed the title
pickle import in py3compat.pypickle import in py3compat.py and some fixes to the main window tests
|
@dalthviz, this is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is required to have compatibility with the latest version of
spyder-line-profiler.I also made the following fixes to our test suite, which I noticed after merging PR #20425:
test_switch_to_pluginrun beforetest_tour_message. This makes that test pass the first time is run, instead of requiring a second time.preferences_dialog_helperto the main windowconftest.pyfiles and mark some of its tests as flaky. This makes the main window tests more reliable.Issue(s) Resolved
Fixes #20430.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12