PR: Skip IPython versions that give buggy code completions and other fixes for dependencies #20656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse_version calls the equivalent of packaging.parse at the end, so it's better to use it directly.
…odule_installed Commas are used both by Conda-build and Setuptools, so our usage of semicolon is non-standard and prone to confusions.
subrepo: subdir: "external-deps/spyder-kernels" merged: "7156204ef" upstream: origin: "https://github.com/spyder-ide/spyder-kernels.git" branch: "2.x" commit: "7156204ef" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
dalthviz
reviewed
Mar 8, 2023
There was a problem hiding this comment.
Thanks @ccordoba12 ! Maybe we should try to add a regression test for the console completion? In that way we could detect in the future if some other version of IPython breaks things here.
Other than that this LGTM 👍
dalthviz
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
parse_versionfrom thepkg_resourcesmodule forparsefrom thepackagingone. The first one basically calls the second one, so it's better to use the later directly.!=operator tois_module_installed.is_module_installed. Commas are used both by Conda-build and Setuptools, so our usage of semicolons is non-standard and prone to confusions.Issue(s) Resolved
Fixes #20393.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: