Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Ensure Pythonpath Manager widget is in front and has focus after adding path on macOS #20812

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Apr 12, 2023

Description of Changes

  • Ensure that PYTHONPATH Manager widget is the front window and has focus after adding a path.
  • Do not update paths upon the path_manager_action if the widget is already visible

These changes should be rebased after merging #20811.
After merging into 5.x, these changes may be merged into master.

Issue(s) Resolved

Fixes #20808

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @mrclary

@mrclary mrclary self-assigned this Apr 12, 2023
@ccordoba12 ccordoba12 changed the title PR: Ensure PYTHONPATH Manager widget is in front and has focus after adding path PR: Ensure Pythonpath Manager widget is in front and has focus after adding path Apr 12, 2023
@ccordoba12 ccordoba12 added this to the v5.4.4 milestone Apr 12, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help with this @mrclary!

spyder/plugins/pythonpath/container.py Show resolved Hide resolved
spyder/plugins/pythonpath/widgets/pathmanager.py Outdated Show resolved Hide resolved
@ccordoba12
Copy link
Member

@mrclary, I think you need to rebase this PR to get the fixes in #20817.

@ccordoba12 ccordoba12 changed the title PR: Ensure Pythonpath Manager widget is in front and has focus after adding path PR: Ensure Pythonpath Manager widget is in front and has focus after adding path on macOS Apr 13, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @mrclary!

@ccordoba12 ccordoba12 merged commit 9325bf4 into spyder-ide:5.x Apr 13, 2023
ccordoba12 added a commit that referenced this pull request Apr 13, 2023
@mrclary mrclary deleted the issue-20808b-PPM branch April 13, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants