Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Improve Variable Explorer UX #20868

Merged
merged 41 commits into from
Jul 14, 2023
Merged
Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
60d290e
first changes in variable explorer
jsbautista Apr 24, 2023
87f5f65
changes in variable explorer
jsbautista Apr 24, 2023
e141af6
Merge branch 'master' into VariableExplorerIssues
jsbautista Apr 24, 2023
48eca80
Apply suggestions
jsbautista May 4, 2023
fd97307
Merge branch 'VariableExplorerIssues' of https://github.com/jsbautist…
jsbautista May 4, 2023
a92d52a
Apply suggestions
jsbautista May 4, 2023
bd90a85
Apply suggestions
jsbautista May 8, 2023
191afe1
Merge branch 'master' into VariableExplorerIssues
jsbautista May 8, 2023
4e3ef83
Apply suggestions
jsbautista May 8, 2023
644d55b
Merge branch 'VariableExplorerIssues' of https://github.com/jsbautist…
jsbautista May 8, 2023
c04755e
Apply suggestions
jsbautista May 8, 2023
17b630a
Apply suggestions
jsbautista May 15, 2023
d61b818
Apply suggestions
jsbautista May 15, 2023
ee61c05
Apply suggestions
jsbautista May 18, 2023
5446cb8
Merge branch 'master' into VariableExplorerIssues
jsbautista May 18, 2023
111a90c
Update spyder/plugins/variableexplorer/widgets/main_widget.py
jsbautista May 29, 2023
06b6d2e
Merge branch 'master' into VariableExplorerIssues
jsbautista May 29, 2023
4bb6b65
Apply suggestions from code review
jsbautista Jun 5, 2023
f146d1c
Apply suggestions
jsbautista Jun 6, 2023
f6ca198
Merge branch 'master' into VariableExplorerIssues
jsbautista Jun 13, 2023
b1fba82
git subrepo pull --remote=https://github.com/jsbautista/spyder-kernel…
jsbautista Jun 13, 2023
4028882
Merge branch 'master' into VariableExplorerIssues
jsbautista Jun 19, 2023
d669a1a
git subrepo pull --remote=https://github.com/jsbautista/spyder-kernel…
jsbautista Jun 19, 2023
d71a5a1
Merge branch 'VariableExplorerIssues' of https://github.com/jsbautist…
jsbautista Jun 19, 2023
429c61a
Apply suggestions
jsbautista Jun 26, 2023
2f08bb1
Merge branch 'master' into VariableExplorerIssues
jsbautista Jun 26, 2023
e85910a
Merge branch 'master' into VariableExplorerIssues
jsbautista Jul 4, 2023
0d2e4ca
Merge branch 'master' into VariableExplorerIssues
jsbautista Jul 7, 2023
079132d
Apply suggestions
jsbautista Jul 10, 2023
cb27172
Merge branch 'VariableExplorerIssues' of https://github.com/jsbautist…
jsbautista Jul 10, 2023
8054316
Apply suggestions
jsbautista Jul 10, 2023
ea6243a
Apply suggestions
jsbautista Jul 10, 2023
b005727
Apply suggestions
jsbautista Jul 10, 2023
c1703d0
Apply suggestions
jsbautista Jul 10, 2023
cd1f439
Apply suggestions
jsbautista Jul 10, 2023
4952a49
Apply suggestions
jsbautista Jul 10, 2023
ae04a3c
Update spyder/widgets/collectionseditor.py
jsbautista Jul 12, 2023
dd82da9
git subrepo pull --remote=https://github.com/spyder-ide/spyder-kernel…
dalthviz Jul 12, 2023
4c68a79
Apply suggestions from code review
dalthviz Jul 13, 2023
7f930d7
Create private API section
dalthviz Jul 13, 2023
a9e895b
Update maininterpreter open preferences logic
dalthviz Jul 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions external-deps/spyder-kernels/.gitrepo

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions external-deps/spyder-kernels/spyder_kernels/utils/nsview.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion spyder/config/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@
'truncate': True,
'minmax': False,
'show_callable_attributes': True,
'show_special_attributes': False
'show_special_attributes': False,
'filter_on': True
}),
('debugger',
{
Expand Down
3 changes: 2 additions & 1 deletion spyder/plugins/ipythonconsole/comms/tests/test_comms.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ def kernel(request):
'False_',
'True_'
],
'minmax': False}
'minmax': False,
'filter_on': True}

# Teardown
def reset_kernel():
Expand Down
3 changes: 2 additions & 1 deletion spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py
Original file line number Diff line number Diff line change
Expand Up @@ -1832,7 +1832,8 @@ def test_pdb_comprehension_namespace(ipyconsole, qtbot, tmpdir):
'excluded_names': [],
'minmax': False,
'show_callable_attributes': True,
'show_special_attributes': False}
'show_special_attributes': False,
'filter_on': True}

shell.call_kernel(
interrupt=True
Expand Down
13 changes: 9 additions & 4 deletions spyder/plugins/variableexplorer/confpage.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,20 @@
from spyder.config.base import _
from spyder.api.preferences import PluginConfigPage


class VariableExplorerConfigPage(PluginConfigPage):

def setup_page(self):
filter_group = QGroupBox(_("Filter"))
filter_data = [
('exclude_private', _("Exclude private references")),
('exclude_capitalized', _("Exclude capitalized references")),
('exclude_uppercase', _("Exclude all-uppercase references")),
('exclude_unsupported', _("Exclude unsupported data types")),
('exclude_private',
_("Exclude private references")),
('exclude_capitalized',
_("Exclude capitalized references")),
('exclude_uppercase',
_("Exclude all-uppercase references")),
('exclude_unsupported',
_("Exclude unsupported data types")),
('exclude_callables_and_modules',
_("Exclude callables and modules"))
]
Expand Down
14 changes: 13 additions & 1 deletion spyder/plugins/variableexplorer/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,19 @@ def get_icon(self):
return self.create_icon('dictedit')

def on_initialize(self):
pass
widget = self.get_widget()
widget.sig_open_preferences_requested.connect(
self._open_preferences
)

def _open_preferences(self):
ccordoba12 marked this conversation as resolved.
Show resolved Hide resolved
"""Open the Preferences dialog in the Variable Explorer section."""
self._main.show_preferences()
preferences = self._main.preferences
container = preferences.get_container()
dlg = container.dialog
index = dlg.get_index_by_name(self.NAME)
dlg.set_current_index(index)
dalthviz marked this conversation as resolved.
Show resolved Hide resolved

@on_plugin_available(plugin=Plugins.Preferences)
def on_preferences_available(self):
Expand Down
Loading
Loading