PR: Fix pylsp import after renaming a module there #21496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subrepo: subdir: "external-deps/python-lsp-server" merged: "1c4ad711de" upstream: origin: "https://github.com/python-lsp/python-lsp-server.git" branch: "develop" commit: "1c4ad711de" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
ccordoba12
force-pushed
the
rename-pylsp-utils
branch
from
974b637
to
0662490
Compare
|
This turned out to be a bad idea (see python-lsp/python-lsp-server#481 for the reasons) so I'm closing it. I'll have to think more carefully about how to make this work in a way that doesn't break other PyLSP plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
_utilsmodule toutilspython-lsp/python-lsp-server#480Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12