PR: Fix adding corner widgets in dockable plugins (API) #22006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-04-18 00:17:17 UTC |
That's because we're going to need them in other modules of spyder.api.widgets too.
- That's cumbersome and not really necessary. Instead, we can use as id the `name` attribute that most of our API widgets have. - Use an enum for the IPython console corner widgets with their respective names. - Allow to pass a name when creating spinners.
- Also, allow to add either widgets or actions as corner widgets. - Use all that to simplify the way corner widgets are added in the Variable Explorer.
…Mixin That's not necessary anymore because SpyderWidgetMixin inherits from SpyderToolbarMixin and those widget inherits from it.
ccordoba12
force-pushed
the
fix-adding-to-corner-widget
branch
from
e2f26a1
to
8ad804e
Compare
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
beforekwarg ofPluginMainWidget.add_corner_widgetand remove the need to pass an ID to it to make it simpler.PluginMainWidget.add_corner_widget.Visual changes
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: