-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Initial Editor migration to the new API #21353
Conversation
Hello @dalthviz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-02-27 20:31:48 UTC |
6642e17
to
2e7d523
Compare
3ec2a5c
to
949714e
Compare
15086f4
to
9c426aa
Compare
fa4f3f8
to
14dc366
Compare
14dc366
to
6d6647d
Compare
08b0c16
to
371d7fb
Compare
…into editor_migration
Also, remove unused imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dalthviz for your hard work on this one!
@@ -3268,14 +3267,14 @@ def test_preferences_empty_shortcut_regression(main_window, qtbot): | |||
base_run_cell_advance = CONF.get_shortcut( | |||
'editor', 'run cell and advance') # Should be Shift+Return | |||
base_run_selection = CONF.get_shortcut( | |||
'_', 'run selection') # Should be F9 | |||
'editor', 'run selection and advance') # Should be F9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this shortcut is not global anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this shortcut is defined under editor
(and it has been like that from even before the changes done in this PR):
Line 488 in f109640
'editor/run selection and advance': "F9", |
I think I did this test change most probabIy since I have been running the tests locally and I stumbled across this one failing. Also, cheking this test definition more closely, I think is not being run on the CI. Most probably the reason is that the shortcut change (from _
to editor
+ the shortcut string/name change) was done in the past but the test was not updated and instead skipped?. Should I also remove the CI skip for the test?
Also, add a couple of TODOs to public methods in the Editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dalthviz for your hard work and patience to finally migrate the Editor to the new API!
Note: The failure in our tests is unrelated to this.
This was introduced in PR spyder-ide/spyder#21353
This mirrors the changes in PR spyder-ide/spyder#21353
This mirrors the changes in PR spyder-ide/spyder#21353
Description of Changes
Move Editor to use newest plugins API
Issue(s) Resolved
Fixes #12193
Part of #17468
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz