Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Address small PySide2 compatibility issues #22197

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Jun 22, 2024

Description of Changes

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
Mark Harfouche

@ccordoba12 ccordoba12 changed the title Address small PySide2 compatibility issues PR: Address small PySide2 compatibility issues Jun 25, 2024
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny suggestion for you, the rest looks good to me.

spyder/plugins/editor/widgets/splitter.py Show resolved Hide resolved
@ccordoba12
Copy link
Member

PySide6 still doesn't work. tested with 6.7.0

That version is affected by spyder-ide/qtpy#480. What about older versions?

@hmaarrfk
Copy link
Contributor Author

That version is affected by spyder-ide/qtpy#480. What about older versions?

That workaround is so embedded in my workflows i forgot about that issue we worked on!

I followed the work done in spyder-ide#21685

PySide6 still doesn't work. tested with 6.7.1
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hmaarrfk!

@ccordoba12 ccordoba12 merged commit 04e6bc5 into spyder-ide:master Jun 25, 2024
14 checks passed
@hmaarrfk
Copy link
Contributor Author

PS. still having trouble with PySide6 even for 6.6

I'll continue to investigate over time:

$ QT_API=pyside6 spyder
Could not find the Qt platform plugin "wayland" in ""
Traceback (most recent call last):
  File "/home/mark/miniforge3/envs/dev/bin/spyder", line 17, in <module>
    sys.exit(main())
  File "/home/mark/git/spyder/spyder/app/start.py", line 261, in main
    mainwindow.main(options, args)
  File "/home/mark/git/spyder/spyder/app/mainwindow.py", line 1462, in main
    mainwindow = create_window(MainWindow, app, splash, options, args)
  File "/home/mark/git/spyder/spyder/app/utils.py", line 357, in create_window
    main.setup()
  File "/home/mark/git/spyder/spyder/app/mainwindow.py", line 784, in setup
    PLUGIN_REGISTRY.register_plugin(self, PluginClass,
  File "/home/mark/git/spyder/spyder/api/plugin_registration/registry.py", line 345, in register_plugin
    instance = self._instantiate_spyder5_plugin(
  File "/home/mark/git/spyder/spyder/api/plugin_registration/registry.py", line 187, in _instantiate_spyder5_plugin
    plugin_instance = PluginClass(main_window, configuration=CONF)
  File "/home/mark/git/spyder/spyder/api/plugins/new_api.py", line 330, in __init__
    self._container = container = self.CONTAINER_CLASS(
  File "/home/mark/git/spyder/spyder/plugins/application/container.py", line 83, in __init__
    super().__init__(name, plugin, parent)
  File "/home/mark/git/spyder/spyder/api/widgets/main_container.py", line 119, in __init__
    QWidget.__init__(self, parent)
  File "/home/mark/git/spyder/spyder/api/widgets/mixins.py", line 684, in __init__
    super().__init__()
  File "/home/mark/git/spyder/spyder/api/config/mixins.py", line 293, in __init__
    'A SpyderConfigurationObserver must define a `CONF_SECTION` '
RuntimeError: '__init__' method of object's base class (ApplicationContainer) not called.
(dev) ✘-1 ~
02:59 $ ^C
(dev) ✘-INT ~
03:00 $ ip^C
(dev) ✘-INT ~
03:00 $ mamba list pyside6
# packages in environment at /home/mark/miniforge3/envs/dev:
#
# Name                    Version                   Build  Channel
pyside6                   6.6.2           py310h7a3fa89_1    conda-forge

@ccordoba12
Copy link
Member

ccordoba12 commented Jun 26, 2024

It seems similar to the issues you fixed here, i.e. Pyside not supporting super in classes that do multiple inheritance.

@hmaarrfk
Copy link
Contributor Author

Yeah..... That's what I thought too. I just couldn't find the offending issue.....

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants