-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Remove IPython kernels from the Python console and connect directly to them #2878
PR: Remove IPython kernels from the Python console and connect directly to them #2878
Conversation
…s started by Spyder
…on their external interpreters
… sys.path - This way we can use our config system to configure external kernels too.
FYI: On this branch I can't open an IPython console - I get the below error in the internal console: >>> Traceback (most recent call last):
File "C:\Users\Dave\Code\spyder\spyderlib\plugins\__init__.py", line 503, in <lambda>
toggled=lambda checked: self.toggle_view(checked),
File "C:\Users\Dave\Code\spyder\spyderlib\plugins\ipythonconsole.py", line 689, in toggle_view
self.create_new_client(give_focus=False)
File "C:\Users\Dave\Code\spyder\spyderlib\plugins\ipythonconsole.py", line 876, in create_new_client
self.connect_client_to_kernel(client)
File "C:\Users\Dave\Code\spyder\spyderlib\plugins\ipythonconsole.py", line 1126, in connect_client_to_kernel
client.password)
File "C:\Users\Dave\Code\spyder\spyderlib\plugins\ipythonconsole.py", line 1098, in create_kernel_manager_and_client
kernel_manager.kernel_spec = self.create_kernel_spec()
AttributeError: can't set attribute |
@dhirschfeld, thanks for testing. I'll see what's happening :-) |
…ellWidget This is also going to be needed by HelpWidget, so it's not exclusive to NamepaceBrowserWidget.
…parent is running
…n are written in a console
I think this one is finally ready!! There are some missing things (like inspecting values in the Variable Explorer while debugging) but I'll fix them in 3.1. For now the most important things are working, i.e. the connections with the Editor, Help and Variable Explorer in normal mode. |
👍 |
Perhaps what I did is not the best approach (we could have used comm messages for some parts), but it's working for now ;-) |
Lets create an issue so we can track these things you suggest we use |
Fixes #1860
Fixes #2696
Fixes #2790
Fixes #2844
Fixes #2846
Fixes #2918
Fixes #2945
Fixes #3011
Fixes #3109
This is our fourth iteration(!) to integrate qtconsole within Spyder. The first one was created by Pierre in 2.1, and I Improved what he did in 2.2 and again in 2.3.
The idea this time is to avoid creating IPython kernels as widgets in the Python console, and instead talk to them directly. Of course, this is a major undertaking and so I've been procrastinating to do it for a long time! :-)
The advantages of this approach are:
Tasks: