Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Run tests in macOS #7232

Merged
merged 3 commits into from
May 31, 2018
Merged

PR: Run tests in macOS #7232

merged 3 commits into from
May 31, 2018

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented May 30, 2018

Now that we don't have to support PyQt4 anymore, there's room in Travis to test with macOS.

@ccordoba12 ccordoba12 added this to the v3.3 milestone May 30, 2018
@ccordoba12 ccordoba12 force-pushed the test-in-macos branch 4 times, most recently from dfdc092 to 689df88 Compare May 30, 2018 22:03
@pep8speaks
Copy link

pep8speaks commented May 30, 2018

Hello @ccordoba12! Thanks for updating the PR.

Line 420:80: E501 line too long (83 > 79 characters)
Line 421:80: E501 line too long (81 > 79 characters)
Line 685:80: E501 line too long (84 > 79 characters)
Line 1359:80: E501 line too long (83 > 79 characters)
Line 1360:80: E501 line too long (89 > 79 characters)

Line 42:80: E501 line too long (100 > 79 characters)
Line 42:93: E261 at least two spaces before inline comment
Line 59:80: E501 line too long (100 > 79 characters)
Line 59:93: E261 at least two spaces before inline comment

Line 172:1: E302 expected 2 blank lines, found 1

Comment last updated on May 31, 2018 at 20:14 Hours UTC

@ccordoba12 ccordoba12 force-pushed the test-in-macos branch 14 times, most recently from 57813b0 to 01df3c9 Compare May 31, 2018 20:05
Coverage will be smaller there due to the tests we had to skip
@ccordoba12 ccordoba12 merged commit 54d7e2b into spyder-ide:3.x May 31, 2018
@ccordoba12 ccordoba12 deleted the test-in-macos branch May 31, 2018 20:35
ccordoba12 added a commit that referenced this pull request May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants