Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Rewrite LSPManager to inherit from QObject instead of SpyderPluginWidget #8642

Merged
merged 8 commits into from
Jan 25, 2019
Merged

PR: Rewrite LSPManager to inherit from QObject instead of SpyderPluginWidget #8642

merged 8 commits into from
Jan 25, 2019

Conversation

ccordoba12
Copy link
Member

There's no need for LSPManager to be a full-fledged SpyderPluginWidget.

@ccordoba12 ccordoba12 added this to the v4.0beta2 milestone Jan 24, 2019
@pep8speaks
Copy link

pep8speaks commented Jan 24, 2019 •
edited
Loading

Hello @ccordoba12! Thanks for updating the PR.

Line 170:1: E402 module level import not at top of file

Comment last updated on January 25, 2019 at 13:12 Hours UTC

@ccordoba12 ccordoba12 merged commit 0706e70 into spyder-ide:master Jan 25, 2019
@ccordoba12 ccordoba12 deleted the remove-lspmanager-plugin branch January 25, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0beta2
Development

Successfully merging this pull request may close these issues.
2 participants
@ccordoba12 @pep8speaks