PR: Fix Ctrl+Tab to cycle files on the editor #9400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goanpeca
force-pushed
the
fix/alt-tab-mac
branch
3 times, most recently
from
6ca6368
to
28f4e9a
Compare
I think they can go in the File menu. |
|
Like this @ccordoba12
|
|
Let's put them at the end, i.e. after |
👍 |
|
Ready @ccordoba12
|
ccordoba12
changed the title
This was referenced Jun 4, 2019
PikachuHy
added a commit
to PikachuHy/MyNotes
that referenced
this pull request
Jun 13, 2021
参考 spyder-ide/spyder#9400 核心思想是：Ctrl+Tab触发MenuBar上的Action，然后slot做具体的处理。Qt框架的eventFilter在mac上无法同时捕获Ctrl+Tab键。这个BUG很早就有了。但是一直无法很好的得到处理。 https://bugreports.qt.io/browse/QTBUG-8596 https://stackoverflow.com/questions/20694919/c-qt-osx-qtmetaqtkey-tab-shortcut-bind
|
Hi everyone. Did this eventually got fixed? I've downloaded and installed the latest version of Spyder 5.1.1. for Mac and can't see these newly added options to the file menu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
As per https://bugreports.qt.io/browse/QTBUG-8596, the action needs to be added to a menu for this to work on OSX. Created a "hidden" menu to try this out and it is working :-). now... where should we add these actions? We cannot disable or hide them or this will cease to work
This PR now updates the default shortcut on MAC to use the
controlkey as chrome firefox and similar applications do on OSX.There is a separate issue on the
Spyder Preferencesrelated to setting shortcuts on OSX that usetabandcontrol, which currently do not seem to work.Issue(s) Resolved
Fixes #6055
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @goanpeca